-
Notifications
You must be signed in to change notification settings - Fork 398
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added Calendar QR Code #202
base: develop
Are you sure you want to change the base?
Conversation
@muarachmann Thanks for knocking this out. I agree that Date time formats get really strange across languages and countries. What do you of having |
01c5495
to
12ca3ee
Compare
@SimplyCorey I see I did not cover extra parameters like categories, alarms, reminders, etc. To this effect, I think the structure should be slightly modified to something like this ...
@SimplyCorey Let me know your thought. Also I don't know why the CI keeps failing? it leads to an unauthorized link |
I like that proposed method call. The CI is failing because of a few issues with the code formatting. You should be able to use styleci.org and open a PR request to fix the styling issues using the laravel preset. Worse case I can run the fixer after the PR is wrapped up to get the styling issues fixed. |
Added QR Code Calendar Datatype and wrote some unit tests. Signed-off-by: Mua N. Laurent <[email protected]>
2276cb3
to
c42dd2f
Compare
@SimplyCorey Fixed the issues and added some more test. The Repeat Rule is so cumbersome and lots of parameters which I wont have time for now maybe later. Having to validate each stuff. How about letting this be a Aside that, everything else works from summary to alarm. Let me know your thoughts on this. |
I'm okay with that. Thanks for working on this. Someone else can carry the torch in the future if that feature is wanted at a later time 👍 |
Year is not work correctly it repeat last two digit i.e 2021,1993 select this and output is 2121,9393 ... My code is here below QrCode::style('round')->size(300)->Calendar([ |
This adds the Calendar Datatype interface to the QR code and will solve #116
Usage
@SimplyCorey I think the
summary
,start_date_time
andend_date_time
should be mandatory or at least the summary and start date,. My thoughts, if end date is not provided it takes into consideration the event is a one day event and ends at the same time the following day. Also I choose theY-m-d H:i
since event times usually take those format. Let me know your thoughts or any corrections. So I can complete the tests