Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ux(builder): Remove title from input and output blocks #8878

Open
wants to merge 5 commits into
base: dev
Choose a base branch
from

Conversation

aarushik93
Copy link
Contributor

Title is redundant to Name and not used functionally.

Changes πŸ—οΈ

Remove title from both input and output agent blocks

Checklist πŸ“‹

For code changes:

  • I have clearly listed my changes in the PR description
  • I have made a test plan
  • I have tested my changes according to the test plan:
    • ...
Example test plan
  • Create from scratch and execute an agent with at least 3 blocks
  • Import an agent from file upload, and confirm it executes correctly
  • Upload agent to marketplace
  • Import an agent from marketplace and confirm it executes correctly
  • Edit an agent from monitor, and confirm it executes correctly

For configuration changes:

  • .env.example is updated or already compatible with my changes
  • docker-compose.yml is updated or already compatible with my changes
  • I have included a list of my configuration changes in the PR description (under Changes)
Examples of configuration changes
  • Changing ports
  • Adding new services that need to communicate with each other
  • Secrets or environment variable changes
  • New or infrastructure changes such as databases

@aarushik93 aarushik93 requested a review from a team as a code owner December 4, 2024 10:45
@aarushik93 aarushik93 requested review from Swiftyos and kcze and removed request for a team December 4, 2024 10:45
Copy link

qodo-merge-pro bot commented Dec 4, 2024

PR Reviewer Guide πŸ”

Here are some key observations to aid the review process:

⏱️ Estimated effort to review: 1 πŸ”΅βšͺβšͺβšͺβšͺ
πŸ§ͺΒ No relevant tests
πŸ”’Β No security concerns identified
⚑ Recommended focus areas for review

Breaking Change
Removing the title field from Input and Output blocks could break backward compatibility for existing agents that rely on this field. Verify that no existing functionality depends on these title fields.

@github-actions github-actions bot added platform/backend AutoGPT Platform - Back end platform/blocks labels Dec 4, 2024
Copy link

netlify bot commented Dec 4, 2024

βœ… Deploy Preview for auto-gpt-docs-dev canceled.

Name Link
πŸ”¨ Latest commit f9d02ad
πŸ” Latest deploy log https://app.netlify.com/sites/auto-gpt-docs-dev/deploys/6751abbfe4ac83000815619f

@github-actions github-actions bot added the size/s label Dec 4, 2024
Copy link

netlify bot commented Dec 4, 2024

βœ… Deploy Preview for auto-gpt-docs canceled.

Name Link
πŸ”¨ Latest commit f9d02ad
πŸ” Latest deploy log https://app.netlify.com/sites/auto-gpt-docs/deploys/6751abbfd92fe2000802f47f

Bentlybro
Bentlybro previously approved these changes Dec 4, 2024
@Bentlybro
Copy link
Member

Bentlybro commented Dec 10, 2024

I think the tests that @ntindle setup are failing on this because of the titles being removed from the input & output blocks, want me to see if i can fix this for you @aarushik93 ?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants