Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make video file extension case insensitive #28

Merged
merged 13 commits into from
Aug 16, 2023

Conversation

sfmig
Copy link
Collaborator

@sfmig sfmig commented Aug 15, 2023

Right now, we look for video files in the input directories with the extension provided, but the extension is case sensitive.

This PR:

  • modifies the frame extraction script to search for video files with the provided extension, ignoring its case.
  • includes a simple test (using two very short clips)
  • makes "bboxes labelling" into a Python module (to be able to test its functions)
  • adds a tests github actions workflow

Sorry if it feels like a big PR! But the large number of files is mostly because:

  • I renamed "bboxes labelling" to "bboxes_labelling" to be able to use it as a module, and
  • I added a pyproject.toml file, which has slightly different settings for ruff / black than what we had before, so a few files have been formatted.

So hopefully won't be too tedious to review!

The main content modifications are in:

  • bboxes_labelling/extract_frames_to_label_w_sleap.py
  • tests/test_frame_extraction.py

@sfmig sfmig marked this pull request as ready for review August 16, 2023 11:02
@sfmig sfmig merged commit e9a254c into main Aug 16, 2023
2 checks passed
@sfmig sfmig deleted the smg/frames-extraction-case-extension branch August 16, 2023 12:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants