Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add logging level #237

Merged
merged 1 commit into from
Nov 5, 2024
Merged

Add logging level #237

merged 1 commit into from
Nov 5, 2024

Conversation

sfmig
Copy link
Collaborator

@sfmig sfmig commented Nov 5, 2024

Description

What is this PR?

  • Bug fix
  • Addition of a new feature
  • Other

Why is this PR needed?
The logging level was not set in the tracking script, so some of the info messages were not logged to screen.

What does this PR do?
Moves the setting of the logging level to the app wrapper function, in line with the training and evaluation scripts.

Also checks the PR template works :)

References

\

How has this PR been tested?

Manually, locally.

Does this PR require an update to the documentation?

No.

Checklist:

  • The code has been tested locally --- manually
  • Tests have been added to cover all new functionality
  • The documentation has been updated to reflect any changes
  • The code has been formatted with pre-commit

@codecov-commenter
Copy link

Codecov Report

Attention: Patch coverage is 0% with 1 line in your changes missing coverage. Please review.

Project coverage is 47.97%. Comparing base (b72d4ad) to head (777f500).

Files with missing lines Patch % Lines
crabs/tracker/track_video.py 0.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #237      +/-   ##
==========================================
- Coverage   48.00%   47.97%   -0.04%     
==========================================
  Files          24       24              
  Lines        1531     1532       +1     
==========================================
  Hits          735      735              
- Misses        796      797       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@sfmig sfmig merged commit 420e0f7 into main Nov 5, 2024
7 checks passed
@sfmig sfmig deleted the smg/tracking-logger-level branch November 5, 2024 13:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants