Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Run Inference on cluster #189
base: main
Are you sure you want to change the base?
Run Inference on cluster #189
Changes from 51 commits
4d1383a
94761b8
e4f1bac
0b3ddd9
892914e
66c22be
3fab713
2b0d273
85452af
f056b41
8780c36
56b74ff
a30b0dc
918674d
2d6da1e
e458c6d
29cfea6
ec6886a
83ed342
d3942ff
2900a9e
500d274
7260ca8
def687a
1a5d853
8ca41c3
be6cff9
7117511
45cd8bd
1c56dfc
6077a7e
e5d362f
a114200
17146ad
1e250b0
3ccc258
6d22c4f
bfd97bd
8284157
cf04af3
8d4c5a2
2ffce7a
8663563
9af60ee
86a309b
3d33730
b72b4b3
2b9973e
feace52
7977b48
bff7606
9c0a560
c5bd870
cd497d7
f87814c
586d412
742ee1a
b96d4fb
e8d77f0
5121e45
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I like this one! ✨
Maybe going forwards I can combine them to read a dir or a single video, but this is a great starting point
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nice! ✨
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Maybe instead of an additional CLI argument saying if the input is a directory or not, we could derive it from the path.
We can do this with
is_dir()
andis_file()
fromPathlib
(example here)There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@sfmig Just comeback to this. The directory is in the bash, we only pass each video path as args. I am not quite sure what's the best way to do unless we want to do the loop of the bash in the code. But doesn't seem to be neater