add comments in notebook about slow opencv function

SainsburyWellcomeCentre · Nov 23, 2023 · ff31726 · ff31726
1 parent d9a9e2c
commit ff31726
Show file tree

Hide file tree

Showing 3 changed files with 3 additions and 0 deletions.
diff --git a/crabs/stereo_calibration/extract_pairs_of_frames.py b/crabs/stereo_calibration/extract_pairs_of_frames.py
@@ -320,6 +320,7 @@ def extract_chessboard_frames_from_video(
             # TODO: append 2d coords of corners?
             frame_gray = cv2.cvtColor(frame, cv2.COLOR_BGR2GRAY)
 
+            # TODO: the following is very slow when no chessboard is present
             ret, corners = cv2.findChessboardCorners(
                 frame_gray,
                 (chessboard_config["rows"], chessboard_config["cols"]),

diff --git a/notebooks/notebook_detect_chessboard_in_sampled_frames.py b/notebooks/notebook_detect_chessboard_in_sampled_frames.py
@@ -167,6 +167,7 @@
     img_gray = cv2.cvtColor(img, cv2.COLOR_BGR2GRAY)
 
     # try to detect chessboard corners
+    # TODO: the following is very slow when no chessboard is present
     ret, corners = cv2.findChessboardCorners(
         img_gray,
         (chessboard_config["rows"], chessboard_config["cols"]),

diff --git a/notebooks/notebook_timecodes.py b/notebooks/notebook_timecodes.py
@@ -147,6 +147,7 @@
         # find chessboard
         # to check flags:
         # https://docs.opencv.org/4.x/d9/d0c/group__calib3d.html#ga93efa9b0aa890de240ca32b11253dd4a
+        # TODO: the following is very slow when no chessboard is present
         ret, corners = cv2.findChessboardCorners(
             frame_gray,
             chessboard_tuple,