Skip to content

Commit

Permalink
Small edits to comments
Browse files Browse the repository at this point in the history
  • Loading branch information
sfmig committed Oct 29, 2024
1 parent c91c65e commit 43f2fe9
Showing 1 changed file with 7 additions and 2 deletions.
9 changes: 7 additions & 2 deletions crabs/detector/evaluate_model.py
Original file line number Diff line number Diff line change
Expand Up @@ -102,7 +102,7 @@ def setup_trainer(self):
trained_model_run_name=self.trained_model_run_name,
trained_model_path=self.trained_model_path,
)
# TODO: add these logs to training too
# TODO: add these logs to training job too
logging.info("MLflow logs for current job")
logging.info(f"Experiment name: {self.experiment_name}")
logging.info(f"Run name: {self.run_name}")
Expand Down Expand Up @@ -159,13 +159,18 @@ def evaluate_model(self) -> None:
)

# Run testing
# TODO: Optionally on validation set?
# trainer.validate(
# trained_model,
# data_module,
# )
trainer = self.setup_trainer()
trainer.test(
trained_model,
data_module,
)

# Save images if required
# Save images with bounding boxes if required
if self.args.save_frames:
save_images_with_boxes(
test_dataloader=data_module.test_dataloader(),
Expand Down

0 comments on commit 43f2fe9

Please sign in to comment.