Clear all CI checks on all platforms #402
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
WalkthroughThe proposed changes primarily focus on improving code readability, maintainability, and consistency. This is achieved through addressing linting warnings, updating docstrings, refactoring some parts of the code, and making minor adjustments in variable assignments and dictionary usage. Some changes also involve function signatures and import statements that may impact module resolution and external interfaces. The CI workflow and pre-commit hooks configurations have been updated as well. Changes
Uplevel your code reviews with CodeRabbit ProCodeRabbit ProIf you like this project, please support us by purchasing the Pro version. The Pro version has advanced context, superior noise reduction and several proprietary improvements compared to the open source version. Moreover, CodeRabbit Pro is free for open source projects. |
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
There was a problem hiding this comment.
Files selected (35)
- aeon/analysis/block_plotting.py (2)
- aeon/analysis/movies.py (4)
- aeon/analysis/plotting.py (4)
- aeon/analysis/utils.py (3)
- aeon/dj_pipeline/init.py (1)
- aeon/dj_pipeline/acquisition.py (1)
- aeon/dj_pipeline/create_experiments/insert_experiment_directory.ipynb (2)
- aeon/dj_pipeline/docs/notebooks/diagram.ipynb (3)
- aeon/dj_pipeline/docs/notebooks/social_experiments_block_analysis.ipynb (2)
- aeon/dj_pipeline/populate/worker.py (2)
- aeon/dj_pipeline/qc.py (1)
- aeon/dj_pipeline/scripts/clone_and_freeze_exp01.py (1)
- aeon/dj_pipeline/scripts/clone_and_freeze_exp02.py (2)
- aeon/dj_pipeline/scripts/update_timestamps_longblob.py (1)
- aeon/dj_pipeline/tracking.py (1)
- aeon/dj_pipeline/utils/load_metadata.py (3)
- aeon/io/api.py (2)
- aeon/io/device.py (3)
- aeon/io/reader.py (3)
- aeon/io/video.py (1)
- aeon/qc/video.py (1)
- aeon/schema/core.py (1)
- aeon/schema/dataset.py (1)
- aeon/schema/foraging.py (1)
- aeon/schema/schemas.py (1)
- aeon/schema/social_02.py (3)
- aeon/schema/streams.py (2)
- aeon/util.py (1)
- docs/examples/dj_example_octagon1_experiment.ipynb (8)
- docs/examples/understanding_aeon_data_architecture.ipynb (20)
- tests/conftest.py (3)
- tests/dj_pipeline/test_acquisition.py (1)
- tests/dj_pipeline/test_pipeline_instantiation.py (1)
- tests/dj_pipeline/test_tracking.py (2)
- tests/io/test_api.py (1)
Files ignored due to filter (1)
- pyproject.toml
Files not summarized due to errors (1)
- docs/examples/understanding_aeon_data_architecture.ipynb (diff tokens exceeds limit)
Files skipped from review due to trivial changes (19)
- aeon/analysis/block_plotting.py
- aeon/analysis/utils.py
- aeon/dj_pipeline/init.py
- aeon/dj_pipeline/acquisition.py
- aeon/dj_pipeline/create_experiments/insert_experiment_directory.ipynb
- aeon/dj_pipeline/docs/notebooks/diagram.ipynb
- aeon/dj_pipeline/docs/notebooks/social_experiments_block_analysis.ipynb
- aeon/dj_pipeline/scripts/update_timestamps_longblob.py
- aeon/dj_pipeline/utils/load_metadata.py
- aeon/io/api.py
- aeon/io/reader.py
- aeon/qc/video.py
- aeon/schema/core.py
- aeon/schema/social_02.py
- docs/examples/dj_example_octagon1_experiment.ipynb
- tests/conftest.py
- tests/dj_pipeline/test_acquisition.py
- tests/dj_pipeline/test_tracking.py
- tests/io/test_api.py
Review comments generated (40)
- Review: 17
- LGTM: 23
Tips
Chat with 
CodeRabbit Bot (@coderabbitai)
- Reply on review comments left by this bot to ask follow-up questions. A review comment is a comment on a diff or a file.
- Invite the bot into a review comment chain by tagging
@coderabbitaiin a reply.
Code suggestions
- The bot may make code suggestions, but please review them carefully before committing since the line number ranges may be misaligned.
- You can edit the comment made by the bot and manually tweak the suggestion if it is slightly off.
Pausing incremental reviews
- Add
@coderabbitai: ignoreanywhere in the PR description to pause further reviews from the bot.
|
@glopesdev Thanks |
There was a problem hiding this comment.
Files selected (7)
- aeon/dj_pipeline/analysis/block_analysis.py (7)
- aeon/dj_pipeline/populate/worker.py (2)
- aeon/dj_pipeline/utils/streams_maker.py (1)
- aeon/io/reader.py (10)
- tests/dj_pipeline/test_pipeline_instantiation.py (1)
- tests/dj_pipeline/test_qc.py (1)
- tests/io/test_api.py (2)
Files skipped from review due to trivial changes (2)
- aeon/dj_pipeline/utils/streams_maker.py
- tests/dj_pipeline/test_pipeline_instantiation.py
Review comments generated (22)
- Review: 11
- LGTM: 11
Tips
Chat with CodeRabbit Bot (@coderabbitai)
- Reply on review comments left by this bot to ask follow-up questions. A review comment is a comment on a diff or a file.
- Invite the bot into a review comment chain by tagging
@coderabbitaiin a reply.
Code suggestions
- The bot may make code suggestions, but please review them carefully before committing since the line number ranges may be misaligned.
- You can edit the comment made by the bot and manually tweak the suggestion if it is slightly off.
Pausing incremental reviews
- Add
@coderabbitai: ignoreanywhere in the PR description to pause further reviews from the bot.
There was a problem hiding this comment.
Files selected (1)
- .github/workflows/build_env_run_tests.yml (1)
Review comments generated (3)
- Review: 2
- LGTM: 1
Tips
Chat with CodeRabbit Bot (@coderabbitai)
- Reply on review comments left by this bot to ask follow-up questions. A review comment is a comment on a diff or a file.
- Invite the bot into a review comment chain by tagging
@coderabbitaiin a reply.
Code suggestions
- The bot may make code suggestions, but please review them carefully before committing since the line number ranges may be misaligned.
- You can edit the comment made by the bot and manually tweak the suggestion if it is slightly off.
Pausing incremental reviews
- Add
@coderabbitai: ignoreanywhere in the PR description to pause further reviews from the bot.
glopesdev
force-pushed
the
gl-ruff-check
branch
from
c904feb
to
6bacc43
Compare
lochhh
reviewed
Sep 19, 2024
glopesdev
changed the title
Welcome to Codecov 🎉Once you merge this PR into your default branch, you're all set! Codecov will compare coverage reports and display results in all future pull requests. Thanks for integrating Codecov - We've got you covered ☂️ |
2 tasks
glopesdev
force-pushed
the
gl-ruff-check
branch
from
9fc495d
to
8515298
Compare
glopesdev
force-pushed
the
gl-ruff-check
branch
from
204b4bf
to
2107691
Compare
glopesdev
changed the title
glopesdev
added
feature
* Persist venv across job steps * Update codecov-action version * Remove `env_config`
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We have failing CI checks for a long time now purely because of ruff linting and pyright warnings. This PR clears all these warnings, either by addressing the suggestions, or ignoring the warnings where reasonable, e.g. docstrings on magic methods, etc.
The current PR is taking us from ~250 errors to zero errors. The final errors were grouped into the below 4 types and have all been resolved:
aeon\io\reader.py:338 and 341: PLR2004 Magic value used in comparison, consider replacing0.3with a constant variableaeon\dj_pipeline\utils\streams_maker.py:129:9: PLW2901forloop variablecoloverwritten by assignment targetaeon\dj_pipeline\populate\worker.py:49:5: F841 Local variableexperiment_namesis assigned to but never useddictcall (rewrite as a literal) inaeon\dj_pipeline\analysis\block_analysis.pyTo reproduce the required checks:
run
pre-commit installandpre-commit run --all-filesor see Workflow run
In the process we have also now enabled resolving all checks for all platforms, including resolving an outstanding issue for datajoint macOS wheels (see #406)
Fixes #411
Fixes #412
Fixes #344
Fixes #249
@coderabbitai: ignore
Summary by CodeRabbit