Add table & reader for Environment Active Configuration

[ttngu207]

Fix #391

[glopesdev]

Pulling out specific attributes from the JSON into columns might be a common enough operation that we could provide it at the level of the general reader, i.e. provide a columns property to specify which values to pull out from each record.

[ttngu207]

Yes, that is a common operation that we should support more generally.

The tricky part is from where do we pull these additional columns out?
In the ActiveConfig jsonl file, we know we want to pull from the column named value from the file, but more generally, we wouldn't necessarily know this.

Perhaps we would then pass instead of just columns, but a tuple of (col_name_to_pull, attr_to_pull_from)
But my concern is that this logic is not longer at the level of general reader.

Any other thoughts/suggestions would be great

[ttngu207]

For example, we can do something like this:

class JsonList(Reader):
    """Extracts data from json list (.jsonl) files, where the key "seconds"
    stores the Aeon timestamp, in seconds.
    """

    def __init__(self, pattern, columns=None, col_tuples=[], extension="jsonl"):
        super().__init__(pattern, columns, extension)
        self.col_tuples = col_tuples

    def read(self, file):
        """Reads data from the specified jsonl file."""
        with open(file, "r") as f:
            df = pd.read_json(f, lines=True)
        df.set_index("seconds", inplace=True)
        for new_col, from_attr in self.col_tuples:
            df[new_col] = df.apply(lambda x: x[from_attr])
        return df

[ttngu207]

(with better naming... col_tuples is a horrible name)

[jkbhagatio]

@glopesdev I don't have a strong preference on whether the pulling out of the column names occurs (whether in JsonList or in the lower-level Reader), so I guess you can make a final call here and then we can just go with that?

[glopesdev]

Suggested change

	class EnvActiveConfigReader(_reader.JsonList):
	class ActiveConfigurationReader(_reader.JsonList):

The names of the reader and stream don't line up, since one is EnvActiveConfig and the other is ActiveConfiguration. Why not just rename the reader as ActiveConfigurationReader? I think the Env prefix might be unnecessary in this context.

[ttngu207]

Agreed, I'll rename

[jkbhagatio]

In this case I actually like the Env prefix because it's more readable

[ttngu207]

I've renamed to EnvActiveConfigurationReader - keeping the Env here to communicate more explicitly that this is for the Environment Active Configuration, just ActiveConfiguration may be too vague or too general

[glopesdev]

Would be nice if we can agree on whether to use Config or Configuration as a common suffix for all classes dealing with these files. I think I am fine either way.

[jkbhagatio]

would actually add Env here too

[glopesdev]

All looks great, I would just rename this stream to be called EnvironmentActiveConfiguration rather than the shorthand version, but not critical either way.

[ttngu207]

Done

[ttngu207]

@jkbhagatio should be ready to merge now