Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactored tests to use absolute file paths #242

Merged
merged 3 commits into from
Sep 14, 2023
Merged

Conversation

jkbhagatio
Copy link
Member

@jkbhagatio jkbhagatio commented Aug 30, 2023

Summary by CodeRabbit

  • Refactor: Enhanced the 'aeon' top-level namespace by making the load function directly accessible, improving code readability and ease of use.
  • Test: Updated tests in 'test_api.py' to utilize absolute file paths instead of relative ones, increasing test reliability across different environments.
  • Chore: Imported the Path class from the pathlib module for handling filesystem paths in a manner consistent with different operating systems.

@jkbhagatio jkbhagatio requested a review from glopesdev August 30, 2023 23:34
Copy link
Contributor

@glopesdev glopesdev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This sounds good, although I would wait until we resolve #238 so we can have our beloved aeon.load back?

@jkbhagatio jkbhagatio requested a review from glopesdev August 31, 2023 22:59
@jkbhagatio
Copy link
Member Author

This sounds good, although I would wait until we resolve #238 so we can have our beloved aeon.load back?

@glopesdev Done - check now?

@github-actions
Copy link

github-actions bot commented Sep 14, 2023

Image description CodeRabbit

Walkthrough

The changes primarily focus on enhancing the code's maintainability and modularity. The load function is now directly accessible under the 'aeon' top-level namespace, improving its accessibility and usage. Additionally, the tests have been refactored to use absolute file paths instead of relative ones, increasing their reliability across different environments.

Changes

Files Summary
aeon/init.py Added an import statement to make the load function available directly under the 'aeon' top-level namespace.
tests/io/test_api.py Refactored the tests to use absolute file paths instead of relative paths by importing the Path class from the pathlib module. Modified the test functions to use these absolute paths when calling the aeon.load() function.

Uplevel your code reviews with CodeRabbit Pro

CodeRabbit Pro

If you like this project, please support us by purchasing the Pro version. The Pro version has advanced context, superior noise reduction and several proprietary improvements compared to the open source version. Moreover, CodeRabbit Pro is free for open source projects.

@jkbhagatio jkbhagatio linked an issue Sep 14, 2023 that may be closed by this pull request
@jkbhagatio jkbhagatio merged commit 4f98897 into main Sep 14, 2023
5 of 7 checks passed
Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Image description CodeRabbit

Commits Files that changed from the base of the PR and between 3b53953 and c60a0f9 commits.
Files selected (2)
  • aeon/init.py (1)
  • tests/io/test_api.py (1)
Files skipped from review due to trivial changes (2)
  • aeon/init.py
  • tests/io/test_api.py
Review comments generated (0)
  • Review: 0
  • LGTM: 0

Tips

Chat with Image description CodeRabbit Bot (@coderabbitai)

  • Reply on review comments left by this bot to ask follow-up questions. A review comment is a comment on a diff or a file.
  • Invite the bot into a review comment chain by tagging @coderabbitai in a reply.

Code suggestions

  • The bot may make code suggestions, but please review them carefully before committing since the line number ranges may be misaligned.
  • You can edit the comment made by the bot and manually tweak the suggestion if it is slightly off.

Pausing incremental reviews

  • Add @coderabbitai: ignore anywhere in the PR description to pause further reviews from the bot.

@jkbhagatio jkbhagatio deleted the refactor_tests branch October 3, 2023 21:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Standardize 'aeon' imports
2 participants