Synchronizer monitor mean timestamps only used when devices report heartbeats #224
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
glopesdev
reviewed
Oct 21, 2024
- When no devices report a heartbeat, DescriptiveStatistics yields a NaN. In this scenario the mean timestamp considered is taken from the synchronizer heartbeat that triggered the BufferTrigger. Co-authored-by: NeuroThom <[email protected]>
aspaNeuro
force-pushed
the
synchronizer-monitor
branch
from
f66fbe9
to
8cd7b22
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When no devices report a heartbeat, DescriptiveStatistics yields a NaN. In this scenario the mean timestamp considered is taken from the synchronizer heartbeat that triggered the BufferTrigger.
Fixes #172