Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Common components integration tests #82

Merged
merged 19 commits into from
Jun 13, 2023

Conversation

sfmig
Copy link
Collaborator

@sfmig sfmig commented Apr 17, 2023

Integration tests to check if the components common to all pages are created. The common components are the page content container and the sidebar.

For the sidebar, we also check that clicking each link takes you to a page with the expected title.

Right now, if no config file is loaded in the Home tab, each of the subsequent pages will return an error in the browser console (see issue #81). I wrote a test for that and marked it with xfail (expected fail) for now

Closes #27

@sfmig sfmig requested a review from samcunliffe April 17, 2023 14:31
@codecov-commenter
Copy link

codecov-commenter commented Apr 17, 2023

Codecov Report

Merging #82 (f51e266) into main (3c67c43) will increase coverage by 10.17%.
The diff coverage is n/a.

@@             Coverage Diff             @@
##             main      #82       +/-   ##
===========================================
+ Coverage   29.94%   40.11%   +10.17%     
===========================================
  Files          12       12               
  Lines         688      688               
===========================================
+ Hits          206      276       +70     
+ Misses        482      412       -70     
Impacted Files Coverage Δ
wazp/app.py 90.90% <ø> (ø)

... and 4 files with indirect coverage changes

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

Copy link
Member

@samcunliffe samcunliffe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🍉🍉

I like this very much, and it runs.

tests/test_integration/test_common_layout.py Outdated Show resolved Hide resolved
tests/test_integration/test_common_layout.py Outdated Show resolved Hide resolved
tests/test_integration/test_common_layout.py Outdated Show resolved Hide resolved
tests/test_integration/test_common_layout.py Show resolved Hide resolved
tests/test_integration/test_common_layout.py Outdated Show resolved Hide resolved
tests/test_integration/test_common_layout.py Outdated Show resolved Hide resolved
tests/test_integration/test_common_layout.py Outdated Show resolved Hide resolved
tests/test_integration/test_common_layout.py Outdated Show resolved Hide resolved
@samcunliffe samcunliffe linked an issue Apr 17, 2023 that may be closed by this pull request
1 task
@samcunliffe
Copy link
Member

This is very close to closing #27 (and potentially that ticket is too nebulous to be very useful).

So I'd propose to declare that this closes #27, reject #61, and then open specific, targetted, user-stories-based issues for individual tests as we need them.

@samcunliffe samcunliffe added the enhancement Optional feature label Apr 17, 2023
@sfmig
Copy link
Collaborator Author

sfmig commented May 18, 2023

hi @samcunliffe, re-requesting a (hopefully quick) review for the parametrised tests. also tagging @niksirbi since he has experience with fixtures inside parametrize input arguments (thanks!)

Ideally I would like to have one fixture with the page name and title of all pages but didn't find a way around it... 🤔
potentially a fix for a future PR?

@sfmig sfmig requested review from niksirbi and samcunliffe May 18, 2023 13:11
So it was an XPASS and we had XFAIL strict (expected fail, but found the
test to pass therefore FAIL). Without strict we get an XPASS on Windows.
Something to investigate further as we add more tests.
@samcunliffe
Copy link
Member

@sfmig : d91f1e8

The error list is empty for the ROI page test on Windows. (No idea why 🙃, but that's why this wasn't passing... strict XFAIL fails on XPASS.)

Can haz merge?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement Optional feature
Projects
None yet
Development

Successfully merging this pull request may close these issues.

webapp testing
3 participants