-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add basic docs with sphinx #45
Conversation
That was quick! |
Well, the build is currently failing. So still, some debugging to do. |
Codecov Report
@@ Coverage Diff @@
## main #45 +/- ##
=====================================
Coverage 9.38% 9.38%
=====================================
Files 4 4
Lines 373 373
=====================================
Hits 35 35
Misses 338 338 📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
Summary of changes
Remaining issues
|
😻 It looks really nice 👍 👍 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks really good 😻!!!
I've left some pedantic comments for our new user-facing README.
I didn't comb through CONTRIBUTING quite so thoroughly because I expect it will evolve a fair bit and this is already an excellent base from which to build.
Currently I have not included any API docs (I don't we need that for now, since the users be interacting with the dashboard, not directly calling Python functions). That said, it will be easy to auto-generate API docs with Sphinx, should we need them in the future.
I'd put them in right now if it's easy. Can you simply autodoc
the lot? If it's a pain then merge this PR first.
Actual instructions on how to use the dashboard are currently missing, but I figured that these should come in separate PRs. These could take the form of adding more.md files to docs/source, and including them in the table-of-contents in docs/source/index.rst
Agreed.
This is potentially a pro-tip 😎 or potentially patronising if you already know 😬 ... When you mention GH issues on GH PRs and/or comments, you can use some magic words and the issue gets linked/closed. I think we don't close #43 yet. |
Squash-merge in now enforced from settings Co-authored-by: Sam Cunliffe <[email protected]>
Co-authored-by: Sam Cunliffe <[email protected]>
Co-authored-by: Sam Cunliffe <[email protected]>
I actually knew this, but deliberately didn't use one of the magic words (since when I opened the PR I wasn't sure which issues would be closed by it 😈 ). Now however I can say with confidence that this PR closes #25 😉 |
This will tackle issues #25 and #43