Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[pre-commit.ci] pre-commit autoupdate #98

Merged
merged 3 commits into from
Sep 22, 2023
Merged

Conversation

pre-commit-ci[bot]
Copy link
Contributor

@pre-commit-ci pre-commit-ci bot commented Aug 28, 2023

@pre-commit-ci pre-commit-ci bot force-pushed the pre-commit-ci-update-config branch from a972913 to e36d3f5 Compare August 28, 2023 22:09
@pre-commit-ci pre-commit-ci bot force-pushed the pre-commit-ci-update-config branch from e36d3f5 to 2609a30 Compare September 4, 2023 22:40
@pre-commit-ci pre-commit-ci bot force-pushed the pre-commit-ci-update-config branch from 2609a30 to 03826f2 Compare September 11, 2023 23:07
updates:
- [github.com/astral-sh/ruff-pre-commit: v0.0.284 → v0.0.290](astral-sh/ruff-pre-commit@v0.0.284...v0.0.290)
- [github.com/psf/black: 23.7.0 → 23.9.1](psf/black@23.7.0...23.9.1)
@pre-commit-ci pre-commit-ci bot force-pushed the pre-commit-ci-update-config branch from 03826f2 to 46118ea Compare September 18, 2023 22:46
@niksirbi
Copy link
Member

The new version of black complains if you do type comparisons such as:

if type(variable) == list:

Instead, it's recommended to use:

if isinstance(variable, list):

@SainsburyWellcomeCentre/neuralplayground is anyone willing to undertake this fix? I'm happy to do it otherwise.

@niksirbi niksirbi self-requested a review September 19, 2023 12:38
@niksirbi
Copy link
Member

I fixed the issue with the type comparisons, and I also set the pre-commit auto-update frequency to monthly (so these bot PRs don's come too often). I'll merge this as soon as the CI passes.

@codecov-commenter
Copy link

codecov-commenter commented Sep 21, 2023

Codecov Report

Merging #98 (82422e6) into main (8685528) will decrease coverage by 0.12%.
Report is 1 commits behind head on main.
The diff coverage is 32.00%.

@@            Coverage Diff             @@
##             main      #98      +/-   ##
==========================================
- Coverage   55.39%   55.27%   -0.12%     
==========================================
  Files          40       40              
  Lines        3428     3439      +11     
==========================================
+ Hits         1899     1901       +2     
- Misses       1529     1538       +9     
Files Changed Coverage Δ
neuralplayground/arenas/arena_core.py 58.92% <ø> (ø)
neuralplayground/arenas/simple2d.py 93.00% <ø> (-0.07%) ⬇️
neuralplayground/experiments/experiment_core.py 70.00% <ø> (ø)
neuralplayground/experiments/hafting_2008_data.py 67.58% <ø> (ø)
neuralplayground/plotting/plot_utils.py 34.24% <5.55%> (-2.25%) ⬇️
.../whittington_2020_extras/whittington_2020_model.py 87.08% <100.00%> (ø)
.../whittington_2020_extras/whittington_2020_utils.py 42.47% <100.00%> (ø)
neuralplayground/config/plot_config.py 100.00% <100.00%> (ø)

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@niksirbi niksirbi merged commit 73e28aa into main Sep 22, 2023
16 checks passed
@niksirbi niksirbi deleted the pre-commit-ci-update-config branch September 22, 2023 12:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants