TEM branch merger #120
Open
TEM branch merger #120
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
for more information, see https://pre-commit.ci
| @@ -104,7 +104,7 @@ pip install NeuralPlayground==0.0.5 | |||
|
|
|||
| If you want to contribute to the project, get the latest development version | |||
| from GitHub, and install it in editable mode, including the "dev" dependencies: | |||
|
|
|||
| #### Unix (Linux and macOS) | |||
There was a problem hiding this comment.
Is this really necessary
There was a problem hiding this comment.
I think so. I had some problems early on, cloning the dev version of NeuralPlayground on both Windows and Mac OS. If this has been fixed, then this is redundant and I'll change it.
| @@ -82,7 +82,9 @@ def act(self, obs, policy_func=None): | |||
|
|
|||
| self.obs_history.append(obs) | |||
| if len(self.obs_history) >= 1000: # reset every 1000 | |||
| self.obs_history.pop(0) | |||
| self.obs_history = [ | |||
There was a problem hiding this comment.
Mmmh the main should be better
for more information, see https://pre-commit.ci
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hoping this pull request is all that is necessary to successfully merge whittington_2020 with the main branch.