Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix deprecation warnings raised by tests #118

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

Conversation

niksirbi
Copy link
Member

@niksirbi niksirbi commented Oct 24, 2024

The tests were catching some DeprecationWarniings about some specific syntax elements that will not be supported in future versions of numpy and matplotlib.

In the process of fixing the matplotlib warning, I also discovered a missing colorspace conversion from RGB to BGR (needed for cv2 to properly display colors in the render plots). I've fixed that, but it may no longer be relevant if we decide to drop cv2, as suggested in #117.

@codecov-commenter
Copy link

Codecov Report

Attention: Patch coverage is 88.88889% with 2 lines in your changes missing coverage. Please review.

Project coverage is 55.26%. Comparing base (ddcd22a) to head (a69e156).

Files with missing lines Patch % Lines
neuralplayground/arenas/discritized_objects.py 88.88% 1 Missing ⚠️
neuralplayground/arenas/simple2d.py 88.88% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #118      +/-   ##
==========================================
+ Coverage   55.18%   55.26%   +0.07%     
==========================================
  Files          40       40              
  Lines        3441     3447       +6     
==========================================
+ Hits         1899     1905       +6     
  Misses       1542     1542              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@niksirbi niksirbi marked this pull request as ready for review October 24, 2024 09:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants