-
Notifications
You must be signed in to change notification settings - Fork 369
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
iOS 15 support #401
base: master
Are you sure you want to change the base?
iOS 15 support #401
Conversation
There are some changes to the CoreBluetooth API. Specially to the memory managment Details are described here Polidea#398
…natures (fixed warning)" This reverts commit e02bb01.
Thank you very much @chamira-at for this PR. A dependency of my project depends on this to unblock me of using the latest Swift version. Looking forward for @robnadin 's review. |
@minixT friendly nudge! Is there any chance you could have a look at this PR? |
can you please have a look on this PR ? |
@monikamsc Can you please help us reviewing this PR? |
Hi 👋🏽, Can someone with It has been sometime and this PR is really critical for many projects. Really appreciate your guys hard work and Thank you 🙏🏼 |
Hello, |
Is there anything I can do to help get this merged in? |
Hello @mpiechocki @minixT |
There are some changes to the Core Bluetooth API.
The changes are detailed describe here in this issue
Solution:
Made below classes'
convenience init(…)
methods optionalconvenience init?(…)
and only initialize if pass inparams
required properties(service, characteristic, descriptors) are not deallocated.Example
Caller sites have been always
guard
strogeRefeance
therefore, added an extraguard
for those that are optionally initializable.Test
Test cases are update and force unwrapped for those optional initializable objects.
Other improvement
Fixed deprecated method signature warnings.