Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adds afterTagSave callback to set tag classes properly. #87

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

steventebrinke
Copy link

Changing the colour of tags by setting a class did not work when tags were unchanged after editing ended with the separator, because in that case the DOM element was recreated, but no change event was fired since the tags were unchanged. IMO, not firing a change event when tags are unchanged is correct, so onChange is not suitable for adding classes to tags. Therefore, I added an afterTagSave callback that receives the DOM element of the saved tag, which makes it easier to add custom CSS classes. The demo has been updated accordingly.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant