Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

editable and creatable vars #19

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

leshek-pawlak
Copy link

I think it's nice feature enable to block edit and create tag action.

Sorry for ugly pull request.
I even tried to write changes in GitHub editor.
Always with the same results.

@SimonSteinberger
Copy link
Contributor

It's really a nice feature - just not sure how many people would actually use it. If one or two others also would like to have this, we'll include it right away.

@leshek-pawlak
Copy link
Author

Thanks! In one project I use this plugin only to show categories, which are defined in system. It is clear for me, that it isn't default usage of this plugin.

Maybe it will be useful soon.

@bbbenja
Copy link

bbbenja commented May 31, 2015

+1 I'm interested for the editable config option

@SimonSteinberger
Copy link
Contributor

I just tried the adapted version, but creatable and editable doesn't work as expected here. creatable is a bit of a hackish implementation that doesn't prevent the public method addTag from creating tags. editable works just half way: e.g. you can still reorder tags and delete them.

@Lesyek: For only displaying tags statically, it's better to just use pure CSS styling. Loading the plugin is really quite some overhead in this case.

Implementing both options properly required a bunch of additional IF statements ... not too many, but enough to think twice about use cases. Personally, I always enjoys using slim and lightweight plugins. And slowly, the tagEditor is becoming more and more bulky :-/

Can you point out a specific use case, where this feature is important? Maybe I'm just to blind to see ...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants