Fixes

- Company / Name - Geography / Fr / CodeCommune - Geography / Fr / CodePostal - Geography / Fr / NumeroDepartement
PhantPHP · Apr 21, 2022 · 724c950 · 724c950
1 parent 35f0de4
commit 724c950
Show file tree

Hide file tree

Showing 5 changed files with 20 additions and 3 deletions.
diff --git a/component/Company/Name.php b/component/Company/Name.php
@@ -5,4 +5,12 @@
 
 class Name extends \Phant\DataStructure\Abstract\Value\Varchar
 {
+	const PATTERN = '/^.{1,}$/';
+
+	public function __construct(string $name)
+	{
+		$name = trim($name);
+
+		parent::__construct($name);
+	}
 }
diff --git a/component/Geography/Fr/CodeCommune.php b/component/Geography/Fr/CodeCommune.php
@@ -3,7 +3,7 @@
 
 namespace Phant\DataStructure\Geography\Fr;
 
-final class CodeCommune extends \Phant\DataStructure\Abstract\Value\Varchar
+class CodeCommune extends \Phant\DataStructure\Abstract\Value\Varchar
 {
 	const PATTERN = '/^([0-9])([0-9AB])([0-9]{3})$/';
 

diff --git a/component/Geography/Fr/CodePostal.php b/component/Geography/Fr/CodePostal.php
@@ -3,7 +3,7 @@
 
 namespace Phant\DataStructure\Geography\Fr;
 
-final class CodePostal extends \Phant\DataStructure\Abstract\Value\Varchar
+class CodePostal extends \Phant\DataStructure\Abstract\Value\Varchar
 {
 	const PATTERN = '/^(\d{5})$/';
 

diff --git a/component/Geography/Fr/NumeroDepartement.php b/component/Geography/Fr/NumeroDepartement.php
@@ -3,7 +3,7 @@
 
 namespace Phant\DataStructure\Geography\Fr;
 
-final class NumeroDepartement extends \Phant\DataStructure\Abstract\Value\Varchar
+class NumeroDepartement extends \Phant\DataStructure\Abstract\Value\Varchar
 {
 	const PATTERN = '/^(9[7-8][0-9])|([0-9]{2})|(2[AB])$/';
 

diff --git a/test/Company/NameTest.php b/test/Company/NameTest.php
@@ -5,6 +5,8 @@
 
 use Phant\DataStructure\Company\Name;
 
+use Phant\Error\NotCompliant;
+
 final class NameTest extends \PHPUnit\Framework\TestCase
 {
 	public function testInterface(): void
@@ -19,4 +21,11 @@ public function testInterface(): void
 		$this->assertIsString($name->serialize());
 		$this->assertEquals('Acme', $name->serialize());
 	}
+
+	public function testNotCompliant(): void
+	{
+		$this->expectException(NotCompliant::class);
+
+		new Name('');
+	}
 }