Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Vector layers #839

Draft
wants to merge 20 commits into
base: 0.x
Choose a base branch
from
Draft

Vector layers #839

wants to merge 20 commits into from

Conversation

mrtripie
Copy link
Contributor

@mrtripie mrtripie commented Mar 26, 2023

Text tool is based on @Variable-ind's variation of the tool here: #589 (comment)

  • Currently experimental
  • Plan is to have a text tool implemented for the first version, new shapes and tools to edit them can be added later

TODO:

  • Add translation data

@OverloadedOrama OverloadedOrama mentioned this pull request Mar 27, 2023
1 task
@OverloadedOrama OverloadedOrama changed the base branch from master to 0.x September 4, 2023 17:11
@OverloadedOrama
Copy link
Member

An idea I had that could simplify vector layers a lot was to wait for Godot 4.2 and use Image.load_svg_from_string(). We could store all vector data in SVG format inside the vector cels, then compose a string and draw the vector shapes using that method. This should work well, although I can see two potential issues:

  • We will still need to handle text differently, as Godot can't load svg images that have text, unless they're being rendered as paths.
  • We would need to re-generate the entire SVG string every time a vector shape changes, which could potentially be slow for large images or for cels that contain a lot of vector data.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants