Micorsoft Teams Sample Cookie App Js #1461
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Pawank-MSFT
reviewed
Nov 22, 2024
README.md
Outdated
| @@ -346,6 +347,7 @@ The [Teams Toolkit](https://marketplace.visualstudio.com/items?itemName=TeamsDev | |||
|
|
|||
| [app-virtual-assistant#cs]:samples/app-virtual-assistant/csharp | |||
| [user-scope-web-application#js]:samples/user-scope-web-application/nodejs | |||
| [cookie-app#js]:samples/cookie-app/js | |||
There was a problem hiding this comment.
change sample name "tab-app-cookie"
samples/cookie-app/js/README.md
Outdated
| **Page Cookie** | ||
|  | ||
|
|
||
| **Seam Site Cookie** |
There was a problem hiding this comment.
Incorrect: Seam Site Cookie
Correct: SameSite Cookie
samples/cookie-app/js/README.md
Outdated
| - __*This step is specific to Teams.*__ | ||
| - **Edit** the `manifest.json` contained in the ./appPackage folder to replace your Microsoft App Id (that was created when you registered your app registration earlier) *everywhere* you see the place holder string `{{ANY-GUID-ID}}` (depending on the scenario the Microsoft App Id may occur multiple times in the `manifest.json`) | ||
| - **Edit** the `manifest.json` for `validDomains` and replace `{{DOMAIN-NAME}}` with base Url of your domain. E.g. if you are using ngrok it would be `https://1234.ngrok-free.app` then your DOMAIN-NAME will be `1234.ngrok-free.app` and if you are using dev tunnels then your domain will be like: `12345.devtunnels.ms`. | ||
| - **Zip** up the contents of the `appPackage` folder to create a `manifest.zip` (Make sure that zip file does not contains any subfolder otherwise you will get error while uploading your .zip package) |
There was a problem hiding this comment.
contains should be contain.
| @@ -0,0 +1,44 @@ | |||
| { | |||
| "$schema": "https://developer.microsoft.com/en-us/json-schemas/teams/v1.5/MicrosoftTeams.schema.json", | |||
There was a problem hiding this comment.
Manifest version should be latest 1.19
| { | ||
| "type": "image", | ||
| "order": 100, | ||
| "url": "https://raw.githubusercontent.com/OfficeDev/Microsoft-Teams-Samples/main/samples/meetings-live-code-interview/nodejs/Images/MeetinLiveCodeInterview.gif", |
| } | ||
|
|
||
| function popOutApp() { | ||
| window.open("https://teams-cookie-app.azurewebsites.net/partitioned-cookies.html"); |
There was a problem hiding this comment.
This should be point local (Relative path)
Mohammed-MSFT
added
the
DO NOT MERGE
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.