doc: fix typo and add bold weight to first mention of important terms in r.geomorphon manual page #4831
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
gregorywaynepower
commented
Dec 11, 2024
•
gregorywaynepower
commented
- Adds bolding around the first mention of search radius (L) and relief threshold (d) since the variables are referenced later on in the description.
- Fixes typo in sentence starting with "...There are 3**8 = 6561 possible ternary patterns..."
- Changes "However by eliminating all patterns that are results of either rotation or reflection of other patterns wa set of 498 patterns remain referred as geomorphons. This is a comprehensive and exhaustive set of idealized landforms that are independent of the size, relief, and orientation of the actual landform." to "However by eliminating all patterns that are results of either rotation or reflection of other patterns we get a set of 498 patterns remain referred as geomorphons. This is a comprehensive and exhaustive set of idealized landforms that are independent of the size, relief, and orientation of the actual landform."
github-actions
bot
added
raster
gregorywaynepower
changed the title
neteler
reviewed
Dec 15, 2024
| @@ -23,7 +23,7 @@ <h3>What is geomorphon:</h3> | |||
| nadir angles along the eight principal compass directions. The ternary | |||
| operator converts the information contained in all the pairs of zenith and | |||
| nadir angles into the ternary pattern (8-tuple). The result depends on the | |||
| values of two parameters: search radius (L) and relief threshold (d). The | |||
| values of two parameters: <b>search radius (L)</b> and <b>relief threshold (d)</b>. The | |||
There was a problem hiding this comment.
I am not sure about this suggestion:
searchexists as a parameterreliefdoes not (I checked also old module versions, back to GRASS GIS 7.6).
Looking at the paper (https://www.geomorphometry.org/uploads/pdf/pdf2011/StepinskiJasiewicz2011geomorphometry.pdf) I am not sure if and how the wording needs to be updated.
Maybe @metzm can enlighten us here?
There was a problem hiding this comment.
Is it possible that relief threshold in the text refers to the flat parameter?
There was a problem hiding this comment.
I have no problems with reverting the bolding change.
veroandreo
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.