wxGUI: Removed unused variables in vdigit/ #4728
Open
+4
−12
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
echoix
requested changes
Nov 21, 2024
petrasovaa
reviewed
Nov 22, 2024
added 2 commits
November 25, 2024 11:50
echoix
requested changes
Dec 14, 2024
| @@ -712,7 +712,7 @@ def SelectLineByPoint(self, point, ltype=None, poMapInfo=None): | |||
| pz = c_double() | |||
| if not self._validLine(lineNearest): | |||
| return {"line": -1, "point": None} | |||
| ftype = Vect_read_line(poMapInfo, self.poPoints, self.poCats, lineNearest) | |||
| _ = Vect_read_line(poMapInfo, self.poPoints, self.poCats, lineNearest) | |||
There was a problem hiding this comment.
I think there might be an issue here, as the gettext translation function _() is using the underscore name, and here it is assigning something else. I would expect that everything calling a translation after this line to be broken (at least in that file).
| @@ -856,7 +856,7 @@ def GetSelectedVertex(self, pos): | |||
|
|
|||
| if not self._validLine(line): | |||
| return -1 | |||
| ftype = Vect_read_line(self.poMapInfo, self.poPoints, self.poCats, line) | |||
| _ = Vect_read_line(poMapInfo, self.poPoints, self.poCats, lineNearest) | |||
There was a problem hiding this comment.
Same thing here, I suspect that assigning to underscore would cause problems. (Unless you can teach me why it works, I'm open to learn if I'm wrong)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
FIxed 'F841' by removing unused variables in
vdigit\