Modernise C++ code #37
Conversation
|
@rouault Thanks for looking at this! Do you deem this safe for a patch release, i.e. 1.0.3? |
This is your call, but IMHO no. |
I agree it is not, I suggested this for 1.1.0 in #38. Very much value your opinion though! |
| OGRFeature *GetNextFeature() override; | ||
| OGRFeature *GetFeature(GIntBig nFeatureId) override; | ||
| virtual auto SetNextByIndex(GIntBig nIndex) -> OGRErr override; | ||
| auto GetNextFeature() -> OGRFeature * override; |
There was a problem hiding this comment.
Just out interest, what guideline you are using for applying the auto...-> return_type syntax generally? (as opposed to just places where it is needed because the type is not known beforehand)
There was a problem hiding this comment.
It is a purely stylistic feature introduced with C++11. In my opinion, coloured after getting accustomed with it in Swift, it provides a bit cleaner interface (lifts up the function/method names in the declaration).
Clang-tidy has a check for this: https://clang.llvm.org/extra/clang-tidy/checks/modernize/use-trailing-return-type.html.
There was a problem hiding this comment.
It fits with the type annotations in Python which is nice (although auto being in place of def is little strange). I just haven't seen a guideline suggesting to apply it generally. With a automated check available - at least in clang-tidy - I can see this can be realistically applied to the code base.
This modernises the C++ code, removing as much C style coding as possible.
I took heavy use of Clang-Tidy, Cppcheck, scan-build to implement this.
It passes the new tests of #36.