-
Notifications
You must be signed in to change notification settings - Fork 488
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update NU1008.md #3331
base: main
Are you sure you want to change the base?
Update NU1008.md #3331
Conversation
Explain how to override package version
Learn Build status updates of commit b99ae3a: ✅ Validation status: passed
For more details, please refer to the build report. For any questions, please:
|
|
||
```xml | ||
<!-- In the project file. --> | ||
<PackageReference Include="PackageId" VersionOverride="3.0.0" /> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think there's a chance this might've been omitted on purpose.
While the feature is available, it's not considered a best practice.
cc @jeffkl should have more context on this.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think there's a chance this might've been omitted on purpose.
We shouldn't be hiding information. It just plain wrong.
While the feature is available, it's not considered a best practice.
There are very valid scenarios for this feature - e.g., solutions targeting multiple TFMs.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There's nothing "wrong" in here by not mentioning VersionOverride. The breadth of solutions offered here doesn't make it wrong.
There are very valid scenarios for this feature - e.g., solutions targeting multiple TFM
PackageVersion can be conditioned as well.
I'm not against accepting a changing like this, but I don't agree that not having it is incorrect.
Explain how to override package version