Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add API to enforce ISO15693 mode #225

Merged
merged 6 commits into from
Sep 17, 2024
Merged

Add API to enforce ISO15693 mode #225

merged 6 commits into from
Sep 17, 2024

Conversation

aaronjamt
Copy link
Contributor

@aaronjamt aaronjamt commented Sep 17, 2024 •
edited by Willy-JL
Loading

See flipperdevices/flipperzero-firmware#3885

What's new

  • Adds a new API to the NFC parser to allow applications to enforce a specific parsing mode. Some apps, such as Picopass, will always use one of the modes, so disabling autodetection can help to prevent issues resulting from incorrectly autodetecting the state (i.e. due to noise). It also includes a way to re-enable autodetection, should that be useful in the future.

This PR is identical to flipperdevices/flipperzero-firmware#3885.

For the reviewer

  • I've uploaded the firmware with this patch to a device and verified its functionality
  • I've confirmed the bug to be fixed / feature to be stable

Willy-JL
Willy-JL approved these changes Sep 17, 2024
View reviewed changes
Copy link
Member

@Willy-JL Willy-JL left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@Willy-JL Willy-JL added the enhancement New enhancement or request label Sep 17, 2024
@Willy-JL Willy-JL merged commit 5afc01a into Next-Flip:dev Sep 17, 2024
1 of 2 checks passed
@aaronjamt aaronjamt mentioned this pull request Sep 17, 2024
Merged
@m7i-org m7i-org mentioned this pull request Oct 6, 2024
Closed
Willy-JL added a commit that referenced this pull request Oct 7, 2024
@Willy-JL
Fix compiling unit tests (missing NFC mock for #225)
2c247bc
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Willy-JL Willy-JL Willy-JL approved these changes

@Sil333033 Sil333033 Awaiting requested review from Sil333033 Sil333033 is a code owner

@HaxSam HaxSam Awaiting requested review from HaxSam HaxSam is a code owner

@MatthewKuKanich MatthewKuKanich Awaiting requested review from MatthewKuKanich MatthewKuKanich is a code owner

Assignees

@aaronjamt aaronjamt

Labels
enhancement New enhancement or request
Projects
Momentum Progress Tracker
Status: Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@aaronjamt @Willy-JL