make wasm run in ci again #185
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
CryZe
reviewed
Dec 3, 2024
| @@ -8,6 +8,6 @@ | |||
| rustflags = ["-Ctarget-cpu=native"] | |||
| rustdocflags = ["-Ctarget-cpu=native"] | |||
|
|
|||
| [target.wasm32-wasi] | |||
| [target.wasm32-wasip1] | |||
There was a problem hiding this comment.
You probably need to have the same target config for both in case you want to test the MSRV still. Ideally with a comment to note that it can be removed once the MSRV is 1.81+ or so.
CryZe
reviewed
Dec 3, 2024
.github/workflows/rust.yml
Outdated
Comment on lines
34
to
35
| - { target: wasm32-wasip1, toolchain: "1.61", os: ubuntu-latest, wasmtime: v5.0.0 } | ||
| - { target: wasm32-wasip1, toolchain: stable, os: ubuntu-latest, wasmtime: v5.0.0 } |
There was a problem hiding this comment.
Here without p1 now (only on 1.61 of course).
|
Oh no, what is this: those definitely need a P1 alternative too. |
|
Is that something we can fix here or should we adjust the CI flow to bypass it and file an issue with rust-lang/rust? |
|
Why would we file an issue upstream? You just need to pass the new P1 env vars as well, which should be |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.