feat(core): automatic 422 response when using validator

[mrsafalpiya]

It makes sense to add a 422 response automatically if the controller method uses a validator.

[Julien-R44]

Thanks!

I think it would be better to include this type directly in MakeTuyauResponse type

It would be cleaner, rather than polluting the generated file that lives in the user's codebase.

Also, I think we should include 422 only if a call to validateUsing is found in the controller method. This check is already done, as it extracts the type of the request. Here: https://github.com/Julien-R44/tuyau/blob/main/packages/core/src/codegen/api_types_generator.ts#L395

If no validateUsing is found, then logically there will be no 422 return.

[mrsafalpiya]

I think it would be better to include this type directly in MakeTuyauResponse type

Yes, it would look clearer, but I can't figure out how this would work. Would you happen to have any pointers you could provide?

Also, I think we should include 422 only if a call to validateUsing is found in the controller method.

I'm indeed checking if validateUsing was used first before adding the 422 signature here: https://github.com/Julien-R44/tuyau/pull/15/files#diff-b22cae109b6d4a97f4e7ba6fa1dec8add7fc4db8c7f2eff710a952c37e655ce0R420 (${schemaImport ? ... : ''})

[Julien-R44]

Yes, it would look clearer, but I can't figure out how this would work. Would you happen to have any pointers you could provide?

I think we can just make MakeTuyauResponse accept a second generic HasSchema which is a boolean. If this boolean is true then we include error 422 in the resulting type :

tuyau/packages/utils/src/types.ts

Line 102 in 2f477b3

export type MakeTuyauResponse<T extends (...args: any) => any> = Simplify<

I'm indeed checking if validateUsing was used first before adding the 422 signature here: #15 (files) (${schemaImport ? ... : ''})

Ah yes sorry I don't know how I missed this! Thanks ahah

Otherwise, could you please run a pnpm changeset add and add a quick summary of your change? We use this to version packages and generate changelogs.

Thanks!!

[mrsafalpiya]

I have added a commit with modified MakeTuyauResponse and generated changelog. Please review it.

[Julien-R44]

Looks perfect to me. Thanks a lot dude!