-
-
Notifications
You must be signed in to change notification settings - Fork 5.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Replace MulAddMul
by alpha,beta
in __muldiag
#56360
Open
jishnub
wants to merge
12
commits into
master
Choose a base branch
from
jishnub/diag_mul
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jishnub
force-pushed
the
jishnub/diag_mul
branch
from
October 28, 2024 12:18
ea1943a
to
d321cce
Compare
jishnub
force-pushed
the
jishnub/diag_mul
branch
from
October 29, 2024 13:12
d321cce
to
1014fae
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR replaces
MulAddMul
arguments byalpha, beta
pairs in the multiplication methods involvingDiagonal
matrices, and constructs the objects exactly where they are required. Such an approach improves latency.This PR sets the stage for a similar change for
Bidiagonal
/Tridiaognal
matrices, which would lead to a bigger reduction in latencies.