Support complex pullbacks #23
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #23 +/- ##
==========================================
- Coverage 78.26% 77.10% -1.16%
==========================================
Files 1 1
Lines 345 345
==========================================
- Hits 270 266 -4
- Misses 75 79 +4
Continue to review full report at Codecov.
|
|
Could you please add a test here for the intended use case? |
|
Certainly, though the tests need a few refactors first to make testing these cases more straightforward. Some changes made in #27. More will be necessary. |
|
Also, this PR should use RealDot.jl now that it exists. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Replaces
_dotwith_realdot, which allows for pulling back through functions with complex outputs. Resolves #22. This is currently untested.