Ensure args with [NotBody] do not display within openapi. #550
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
While this seems like a simple change the implementation of this functionality is highly dependent on both aspnetcore ApiExplorer and swashbuckle functionality. My understanding is that the dependency relationship between these is the following EndpointBuilder -> Endpoint -> ApiExplorer -> Swashbuckle. Specifically the functionality which this relies on is implemented here https://github.com/dotnet/aspnetcore/blob/b0b9f45538383bdf036bd35a84c6552d37bd6010/src/Mvc/Mvc.ApiExplorer/src/EndpointMetadataApiDescriptionProvider.cs#L279C120-L287 Closes JasperFx#528
|
@alistair I was gonna tell you in Discord today that I had a couple conversations with wolverine users where they're having to opt out of low ceremony approaches just because of Swagger or NSwag. That makes your work here very timely all the sudden and more important than I guess I realized. I'll try to be getting this in very soon. Thank you! |
|
@jeremydmiller if you have more details on what challenges they have then I can have a look into it. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
While this seems like a simple change the implementation of this functionality is highly dependent on both aspnetcore ApiExplorer and swashbuckle functionality.
My understanding is that the dependency relationship between these is the following
EndpointBuilder -> Endpoint -> ApiExplorer -> Swashbuckle.
Specifically the functionality which this relies on is implemented here https://github.com/dotnet/aspnetcore/blob/b0b9f45538383bdf036bd35a84c6552d37bd6010/src/Mvc/Mvc.ApiExplorer/src/EndpointMetadataApiDescriptionProvider.cs#L279C120-L287
Closes #528