-
-
Notifications
You must be signed in to change notification settings - Fork 140
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added configurable activity tracing #541
base: main
Are you sure you want to change the base?
Conversation
@mfuqua3 Hey, Matt, I'm going to get this in soon, but with a couple minor changes. I'm going to introduce a "composite filter" pattern so you can register separate includes/excludes. Experience says you'd want that and those one size fits all Func<something, bool> is never perfectly usable. The other minor things I'm going to do is pull this:
into each individual Start**** method just to eliminate the lookup. It's a micro-optimization, but you work under the assumption that everything a framework does is the hot path. Question for you, how do you see the Comments aside, thank you for doing this work, I know folks are going to appreciate this one! |
Makes sense. I actually went back and forth initially on whether the code reuse was worth it, so I'm with you there.
So I do not necessarily have an immediate need for this capability. I actually borrowed this concept (and most of the contract for this options class) from another OpenTelemetry instrumentation package -- the WCF one to be specific. I do not anticipate I would use this feature right away, if ever. Although I can anticipate use cases for it:
Also, making it part of the options class allows it to be easily configured in an |
@mfuqua3 Hey Matt, I did take a very close look at this, but decided to do the Otel filtering (and more logging filtering in general) a bit different way -- mostly out of micro-optimization thinking. I will revisit this in 1.8 and use the new extension that adds Otel to Wolverine. That one's a winner. I'll also try to do 1.8 much sooner than the gap was between 1.6 and 1.7 |
Roger that, sounds good! |
This pull request addresses issue #451
It adds configuration support for Wolverine tracing, and adds an additional package for OpenTelemetry instrumentation.
-- OR --