Changed the ServiceVariableSource to be transient so it's never share…

…d and there's no concurrency errors. Closes GH-527
JasperFx · Sep 15, 2023 · feeef61 · feeef61
1 parent 2bfa2ac
commit feeef61
Show file tree

Hide file tree

Showing 2 changed files with 3 additions and 3 deletions.
diff --git a/src/Http/Wolverine.Http/HttpChain.cs b/src/Http/Wolverine.Http/HttpChain.cs
@@ -162,7 +162,7 @@ public static HttpChain ChainFor<T>(Expression<Action<T>> expression, HttpGraph?
         return new HttpChain(call, parent ?? new HttpGraph(new WolverineOptions(), new Container(x =>
         {
             x.For<JsonSerializerOptions>().Use(new JsonSerializerOptions());
-            x.For<IServiceVariableSource>().Use(c => c.CreateServiceVariableSource()).Singleton();
+            x.For<IServiceVariableSource>().Use(c => c.CreateServiceVariableSource()).Transient();
         })));
     }
 
@@ -173,7 +173,7 @@ public static HttpChain ChainFor(Type handlerType, string methodName, HttpGraph?
         return new HttpChain(call, parent ?? new HttpGraph(new WolverineOptions(), new Container(x =>
         {
             x.For<JsonSerializerOptions>().Use(new JsonSerializerOptions());
-            x.For<IServiceVariableSource>().Use(c => c.CreateServiceVariableSource()).Singleton();
+            x.For<IServiceVariableSource>().Use(c => c.CreateServiceVariableSource()).Transient();
         })));
     }
 

diff --git a/src/Wolverine/HostBuilderExtensions.cs b/src/Wolverine/HostBuilderExtensions.cs
@@ -73,7 +73,7 @@ internal static IHostBuilder UseWolverine(this IHostBuilder builder, WolverineOp
 
             services.AddSingleton<IStatefulResource, MessageStoreResource>();
 
-            services.AddSingleton(s => s.GetRequiredService<IContainer>().CreateServiceVariableSource());
+            services.AddTransient(s => s.GetRequiredService<IContainer>().CreateServiceVariableSource());
 
             services.AddSingleton(s =>
             {