Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enhanced File Uploading #173

Merged
merged 8 commits into from
Aug 15, 2024
Merged

Conversation

GPortas
Copy link
Contributor

@GPortas GPortas commented Aug 5, 2024

What this PR does / why we need it:

Enables the ability to add multiple uploaded files to a dataset in a single use case call.

Additionally, the AddUploadedFileToDataset use case now receives a DTO instead of the File Blob that was previously sent to the UploadFile use case. The new DTO includes extended metadata for file to be added to the dataset.

This PR also fixes the issue with integration and functional tests executions on GitHub Actions by updating the testcontainers version to latest.

Which issue(s) this PR closes:

Related Dataverse PRs:

  • None

Special notes for your reviewer:

N/A

Suggestions on how to test this:

Visual inspection of code and github actions.

Is there a release notes update needed for this change?:

N/A

Additional documentation:

N/A

@GPortas GPortas added Size: 3 A percentage of a sprint. 2.1 hours. GREI Re-arch GREI re-architecture-related SPA: File Upload Page labels Aug 6, 2024
@GPortas GPortas marked this pull request as ready for review August 6, 2024 10:07
@g-saracca g-saracca self-assigned this Aug 6, 2024
Copy link
Contributor

@g-saracca g-saracca left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

@ekraffmiller
Copy link
Contributor

@GPortas I got a timing error when a ran npm run test , I think because it exceeded the timeout in jest.config.ts. But when I ran the tests individually, they all passed. Maybe we can increase the timeout?

Screenshot 2024-08-13 at 2 22 24 PM

@GPortas
Copy link
Contributor Author

GPortas commented Aug 15, 2024

@GPortas I got a timing error when a ran npm run test , I think because it exceeded the timeout in jest.config.ts. But when I ran the tests individually, they all passed. Maybe we can increase the timeout?

Screenshot 2024-08-13 at 2 22 24 PM

@ekraffmiller This is the same issue we talked about in other PR. DNS issue related to containers that affects the reachability of them within the network. Restart docker and it should work.

Let me know if it works. I think we may need to create an issue to fix and stabilize this inconsistent behavior.

@ekraffmiller
Copy link
Contributor

ekraffmiller commented Aug 15, 2024

@GPortas I got a timing error when a ran npm run test , I think because it exceeded the timeout in jest.config.ts. But when I ran the tests individually, they all passed. Maybe we can increase the timeout?
Screenshot 2024-08-13 at 2 22 24 PM

@ekraffmiller This is the same issue we talked about in other PR. DNS issue related to containers that affects the reachability of them within the network. Restart docker and it should work.

Let me know if it works. I think we may need to create an issue to fix and stabilize this inconsistent behavior.

@GPortas I restarted multiple times, and I didn't get it to work until I changed the timeout to 35000. That might just be a coincidence, I'm not sure. The interesting thing is that when I ran the individual tests it worked, but the script that runs them all (npm run test) failed.

@ekraffmiller
Copy link
Contributor

ekraffmiller commented Aug 15, 2024

I created another issue for the test failure ( #179) merging.

@ekraffmiller ekraffmiller merged commit 0ea8141 into develop Aug 15, 2024
5 checks passed
@GPortas GPortas added SPA.Q3.5 Enhanced File upload Original size: 3 labels Sep 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
GREI Re-arch GREI re-architecture-related Original size: 3 Size: 3 A percentage of a sprint. 2.1 hours. SPA: File Upload Page SPA.Q3.5 Enhanced File upload
Projects
Status: Done 🧹
Development

Successfully merging this pull request may close these issues.

Improve upload files interface
3 participants