-
Notifications
You must be signed in to change notification settings - Fork 8
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Enhanced File Uploading #173
Conversation
…t instead of File Blob
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good!
@GPortas I got a timing error when a ran |
@ekraffmiller This is the same issue we talked about in other PR. DNS issue related to containers that affects the reachability of them within the network. Restart docker and it should work. Let me know if it works. I think we may need to create an issue to fix and stabilize this inconsistent behavior. |
@GPortas I restarted multiple times, and I didn't get it to work until I changed the timeout to 35000. That might just be a coincidence, I'm not sure. The interesting thing is that when I ran the individual tests it worked, but the script that runs them all ( |
I created another issue for the test failure ( #179) merging. |
What this PR does / why we need it:
Enables the ability to add multiple uploaded files to a dataset in a single use case call.
Additionally, the AddUploadedFileToDataset use case now receives a DTO instead of the File Blob that was previously sent to the UploadFile use case. The new DTO includes extended metadata for file to be added to the dataset.
This PR also fixes the issue with integration and functional tests executions on GitHub Actions by updating the testcontainers version to latest.
Which issue(s) this PR closes:
Related Dataverse PRs:
Special notes for your reviewer:
N/A
Suggestions on how to test this:
Visual inspection of code and github actions.
Is there a release notes update needed for this change?:
N/A
Additional documentation:
N/A