Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

atomic-wallet: update livecheck #195247

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

zyoshoka
Copy link
Contributor

Important: Do not tick a checkbox if you haven’t performed its action. Honesty is indispensable for a smooth review process.

In the following questions <cask> is the token of the cask you're submitting.

After making any changes to a cask, existing or new, verify:

Additionally, if adding a new cask:

  • Named the cask according to the token reference.
  • Checked the cask was not already refused (add your cask's name to the end of the search field).
  • brew audit --cask --new <cask> worked successfully.
  • HOMEBREW_NO_INSTALL_FROM_API=1 brew install --cask <cask> worked successfully.
  • brew uninstall --cask <cask> worked successfully.

Current livecheck returns an older version, so I updated the url.

@khipp khipp added the livecheck Issues or PRs related to livecheck label Dec 14, 2024
@bevanjkay
Copy link
Member

bevanjkay commented Dec 14, 2024

From my testing, although the existing livecheck url is returning an older version, it is being used by the in-app updater.

Casks/a/atomic-wallet.rb Outdated Show resolved Hide resolved
@zyoshoka zyoshoka force-pushed the atomic-wallet-update-livecheck branch from 5aae30a to c0134fa Compare December 14, 2024 14:28
@zyoshoka
Copy link
Contributor Author

To be clear, this endpoint is requested when the download button is clicked on the website. Is the electron-builder appcast preferred than this?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
livecheck Issues or PRs related to livecheck
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants