Minor Updates #48
Minor Updates #48
Conversation
The following changes where performed:
- Line 3: image URL update.
- Line 11: spellchecking.
ghost
changed the title
.gitignore
Outdated
| /.idea/ | ||
| /vendor/ | ||
| # Ignoring files. | ||
| /composer.lock |
There was a problem hiding this comment.
Don't put the composer.lock into .gitignore
https://getcomposer.org/doc/01-basic-usage.md#commit-your-composer-lock-file-to-version-control
There was a problem hiding this comment.
Yes, you're right. Let me fix this.
.gitignore
Outdated
| @@ -1 +1,6 @@ | |||
| vendor | |||
| # Ignoring directories. | |||
| /.idea/ | |||
There was a problem hiding this comment.
.idea seems to be coming from jetbrains, which is a personal folder. Couldn't you just not add this folder to git as well? Fine for me
There was a problem hiding this comment.
I don't entirely agree with you, but it's okay.
| php: | ||
| - 5.3 | ||
| - 5.4 |
There was a problem hiding this comment.
Hm, what about removing the support for such old php versions? I think the performance boost we could have by using PHP 7 could be the last thing needed for this lib to become Mr. worldwide.
Also, if we would support only > PHP 5.6
we could do $addition = new AdditionOperator(SimpleNumber::class); instead of $addition = new AdditionOperator('SimplePHPEasyPlus\Number\SimpleNumber');
There was a problem hiding this comment.
That's not my decision, as I'm not a member of this project, only a contributor.
When I downloaded the project and tried to execute it with Travis CI, I couldn't because the Ubuntu's Trusty version doesn't support the PHP's 5.3 release. So keeping the ability to perform all the previous tests and support those for new PHP versions, I ended up reconfiguring the Travis CI configuration file.
| php: | ||
| - 5.3 |
There was a problem hiding this comment.
Note: removing php 5.3 requires a new major release.
There was a problem hiding this comment.
What do you mean by major release?
.gitignore
Outdated
| /vendor/ | ||
| # Ignoring files. | ||
| /composer.lock |
There was a problem hiding this comment.
Not ignoring this file causes a little problem. I need to generate composer.lock file with the 5.3 PHP's version, otherwise Travis CI cannot perform the tests.
|
Okay, you can accept it. |
I've just seen this library in a Reddit post, and I wanted to contribute to its maintenance.
There's still a lot of things to do, like migration to higher versions of PHPUnit, but I'd like to do it with a little bit more free time.