[#2598] Problematic SVG on Firefox #2623
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
Changh341
changed the title
|
Let me know if changing the icon size on the SVG level is not ok. I will revert and look into doing at a code level. |
|
@Changh341 I've tested, works well, looks good, same for code, but yeah, ideally the svg shouldn't be manually edited at all and have things done via code. |
…ng over creatures.
|
@DreadKnight Got it. I went ahead and scaled down the icon at the phaser level in creature.ts and reverted the sizing on the SVG. |
|
@Changh341 Well done! Merged and bounty sent with bonus -> https://www.mintme.com/explorer/tx/0x4e783f210835cf7f97e258b14115cb977da66ea3d0b85caa5fed1c1806de139a 🪙 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes issue #2598
My wallet address is 0x959E79438e522308587C3687d06bC3A467820119
Issue explanation:
The SVG syntax for width and height were defined in a style attribute in SVG markup. Firefox doesn't seem to read that and loaded the SVG as 0 x 0.
Actions taken:
I instead used the attributes: 'height' and 'width' to define the size which fixed the icon not appearing.
I went ahead and deleted the PNG dupe and moved the SVG into the autoloader.
Slight change to the size of the icon on the SVG markup from 512 x 512 to 128 x 128 because 512 leaked outside the frame.I scaled down the icon appearing above the creatures.
Preview from Firefox:
