Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove deprecated code from SnowBunny.ts #2493

Merged
merged 3 commits into from
Sep 13, 2023

Conversation

allmtz
Copy link
Contributor

@allmtz allmtz commented Sep 11, 2023

Replaced deprecated curr.creature and hex.creature with calls to getPointFacade().

As a side note, I also replaced all instances of target.flipped(aka creature.flipped) with false. No flipped property exists on creature so target.flipped was always undefined.

@vercel
Copy link

vercel bot commented Sep 11, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
ancientbeast ✅ Ready (Inspect) Visit Preview Sep 12, 2023 7:39pm

@ghost
Copy link

ghost commented Sep 11, 2023

👇 Click on the image for a new way to code review

Review these changes using an interactive CodeSee Map

Legend

CodeSee Map legend

@DreadKnight
Copy link
Member

@allmtz Found a bug: If a creature (Uncle Fungus) is in one of the 3 frontal hexagons of Snow Bunny at start of turn and moves to one of the others, it doesn't trigger Snow Bunny's Bunny Hop passive to cause it to leap backwards in the opposite direction.

@allmtz
Copy link
Contributor Author

allmtz commented Sep 12, 2023

@allmtz Found a bug: If a creature (Uncle Fungus) is in one of the 3 frontal hexagons of Snow Bunny at start of turn and moves to one of the others, it doesn't trigger Snow Bunny's Bunny Hop passive to cause it to leap backwards in the opposite direction.

Should be good now. I was with comparing the wrong hex positions for creatures that take up more than 1 tile.

@DreadKnight
Copy link
Member

@allmtz Yeah, works better now 👍🏻
Bumped into some other issue but can't reproduce it properly, anyway, will open up new issue instead if I manage.

@DreadKnight DreadKnight merged commit 259f513 into FreezingMoon:master Sep 13, 2023
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants