Fix Esc key closing Sheets #9969
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
this part does not work for me in Firefox and Edge Win10. |
|
Well I guess more specifically it allows escape to do whatever your platform thinks escape should do. |
|
The linked issue is asking for this on Chrome + Win10 - is that something we'd still want to add to (sheet) inputs in DIM or are we happy with consistency with platform behavior? |
|
Probably I'll consider this not to close that issue, and solve it more directly. |
|
Besides the behavior issue of focusing inputs, do you have any opinions on the PR? |
robojumper
approved these changes
Oct 18, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I noticed that in some cases, sheets couldn't be closed in order by hitting "Esc" - for example, opening a loadout edit sheet, then clicking show mod placement, then hitting Esc wouldn't do anything.
The reason is that the parent sheet would re-render, which would create a new hotkey callback, which would unregister the old callback and register a new one at the front of the hotkey stack.
To fix this, I now track hotkeys by ID so they are always ordered by when they were first inserted, and added some tests.
This does not yet address #6246 since esc to unfocus only works on macOS.