Improve wishlist loading #10844
Merged
Improve wishlist loading #10844
+87
−51
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Wish lists loaded or failed as a group - if one of them was bad, it poisoned them all. This PR changes to show errors for individual lists, and allow the set of wish lists to be edited even if one or more of the lists fails to load, as long as at least one loads. It also shows more useful error messages, and displays how many duplicate rolls were included in a list:
For fun, I also linked to the wish list sources from the "rolls" string.
This might fix #10843, though I'm not 100% sure what their issue is.