Feature/wishlist refresh #10842
Merged
Feature/wishlist refresh #10842
+32
−8
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bhollis
reviewed
Dec 12, 2024
Comment on lines
129
to
131
| <button type="button" className="dim-button" onClick={reloadAllWishListsEvent}> | ||
| <AppIcon icon={refreshIcon} /> {t('WishListRoll.Refresh')} | ||
| </button> |
There was a problem hiding this comment.
If GitHub really does cache for 10 minutes, we probably need to show a warning when this is clicked that explains why it might not be fresh.
There was a problem hiding this comment.
I am learning the patterns still, thought I could add a notification block in the handleReloadEvent right after the update completes reminding them as well as saying "we did it, promise"
chore: code review feedback on changelog format Co-authored-by: Ben Hollis <[email protected]>
chore: standard react event name over established pattern per code review suggestion Co-authored-by: Ben Hollis <[email protected]>
chore: revert to prior attempt without changeUrl Wrapper Co-authored-by: Ben Hollis <[email protected]>
|
@bhollis I think I got all the feedback incorporated for another code review |
bhollis
approved these changes
Dec 13, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added button in the settings screen to force reloading wishlists. Feature linked: #7659