Correctly reverse failed save search / revamp dim-api tests #10811
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Suspect IssuesThis pull request was deployed and Sentry observed the following issues:
Did you find this useful? React with a 👍 or 👎 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In investigating #10809 I found that there were a number of bugs related to reversing DIM Sync actions if they fail. The one that was causing this user to get stuck was a failed "save search" for a search that was too long - because it threw an error every time, it just kept trying the update. I both fixed the logic and put a protective try/catch around the reverse logic, as it isn't critical.
I then overhauled the tests for the dim-api reducer and added in assertions that reversing actions after a failure would return the state to the initial version, and fixed a handful of related bugs.
Fixes #10809