Merge pull request #10832 from DestinyItemManager/vendor-missing-sockets

Don't always say vendor items are missing sockets
DestinyItemManager · Dec 8, 2024 · ecec5e9 · ecec5e9
2 parents b33b39a + b2c1049
commit ecec5e9
Showing 1 changed file with 4 additions and 3 deletions.
diff --git a/src/app/inventory/store/sockets.ts b/src/app/inventory/store/sockets.ts
@@ -68,6 +68,7 @@ export function buildSockets(
   itemDef: DestinyInventoryItemDefinition,
 ): { sockets: DimItem['sockets']; missingSockets: DimItem['missingSockets'] } {
   let sockets: DimSockets | null = null;
+  let missingSockets: DimItem['missingSockets'] = false;
   if ($featureFlags.simulateMissingSockets) {
     itemComponents = undefined;
   }
@@ -102,14 +103,14 @@ export function buildSockets(
     const isInstanced = Boolean(item.itemInstanceId && item.itemInstanceId.length > 14);
 
     // If this really *should* have live sockets, but didn't...
-    if (item.itemInstanceId !== '0' && !socketData) {
-      return { sockets: null, missingSockets: isInstanced ? 'missing' : 'not-loaded' };
+    if (isInstanced && !socketData) {
+      missingSockets = isInstanced ? 'missing' : 'not-loaded';
     }
 
     sockets = buildDefinedSockets(defs, itemDef);
   }
 
-  return { sockets, missingSockets: false };
+  return { sockets, missingSockets };
 }
 
 /**