Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

build: switch to Goooler/shadow fork #415

Merged
merged 1 commit into from
Jun 18, 2024
Merged

build: switch to Goooler/shadow fork #415

merged 1 commit into from
Jun 18, 2024

Conversation

joshuasing
Copy link
Member

Summary
The Gradle shadow plugin by johnrengelman is currently unmaintained, and does not currently support the latest versions of Gradle.

There have been discussions regarding the future of the plugin, however nothing has been acted upon currently: GradleUp/shadow#908

This fork appears to be the most supported and best maintained fork, and has been suggested as the replacement for the original shadow plugin.

Fixes #414
Related to #410

Changes

Checklist

The Gradle shadow plugin by johnrengelman is currently unmaintained, and
does not currently support the latest versions of Gradle.

There have been discussions regarding the future of the plugin, however
nothing has been acted upon currently: GradleUp/shadow#908

This fork appears to be the most supported and best maintained fork, and
has been suggested as the replacement for the original shadow plugin.

Fixes #414
Related to #410
@joshuasing joshuasing requested a review from LooFifteen as a code owner June 17, 2024 09:30
@joshuasing joshuasing added type: dependencies This involves updating, adding or removing a dependency area: build This involves updating, adding or removing a build file type: refactor This refactors existing code labels Jun 17, 2024
@joshuasing joshuasing self-assigned this Jun 17, 2024
Copy link
Member

@LooFifteen LooFifteen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The original shadow seems to work fine for me, but I guess it's time to move considering the original author said so.

@joshuasing joshuasing merged commit 7c2c331 into main Jun 18, 2024
2 checks passed
@joshuasing joshuasing deleted the build/shadow-fork branch June 18, 2024 21:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area: build This involves updating, adding or removing a build file size: XS type: dependencies This involves updating, adding or removing a dependency type: refactor This refactors existing code
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Move to Gradle shadow plugin fork
2 participants