CESIUM_primitive_outline performance #12084
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thank you for the pull request, @MingFanZhu! ✅ We can confirm we have a CLA on file for you. |
|
Thanks for the PR @MingFanZhu. @jjhembd Could you please review this PR? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This commit only change the execution order of
PrimitiveOutlineGenerator.updateAttribute.This can fix performance issues with GLTF extension CESIUM_primitive_outline.
before
after
Issue number and link
Cesium after 1.96 had low performance with GLTF extension CESIUM_primitive_outline #12077
Testing plan
Author checklist
CONTRIBUTORS.mdCHANGES.mdwith a short summary of my change