-
-
Notifications
You must be signed in to change notification settings - Fork 8
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Switch to Yarn plug-and-play #738
base: master
Are you sure you want to change the base?
Conversation
e74dff8
to
f3fff70
Compare
@minht11, looks like both @biomejs/biome and remark-cli are not pnp compliant. |
@Borewit I have zero experience with yarn pnp, but by the looks of it it tries to lint those files. You can just ignore them in biome.jsonc
Tested locally. |
f3fff70
to
72adacf
Compare
package.json
Outdated
@@ -42,7 +42,7 @@ | |||
"lib/**/*.d.ts" | |||
], | |||
"devDependencies": { | |||
"@biomejs/biome": "1.8.3", | |||
"@biomejs/biome": "^1.8.3", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think the version is already pinned using yarn, in yarn.lock
.
Any update typically needs to pass CI, usually triggered via dependabot.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If you have already installed dependencies then yes, but if for example you clone new project ant run npm install it will attempt to download never dependencies matching range, not sure on how specifically yarn handles it, but in this case I think it's better to pin it.
72adacf
to
7326bf7
Compare
It is as if the configuration file is ignored when switching to pnp. You need to run |
The latest breakage is because you enabled |
7326bf7
to
e82f75b
Compare
Great, only remark-cli remaining |
e82f75b
to
9d2ab51
Compare
Reference: https://v3.yarnpkg.com/getting-started/migration#switching-to-plugnplay