Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Move getenv out of a function used in multiple threads #387

Merged
merged 2 commits into from
Nov 4, 2024
Merged

Move getenv out of a function used in multiple threads #387

merged 2 commits into from
Nov 4, 2024

Conversation

nhz2
Copy link
Contributor

@nhz2 nhz2 commented Nov 3, 2024 •
edited
Loading

Fixes #384

kalvdans
kalvdans reviewed Nov 3, 2024
View reviewed changes
blosc/blosc.c Outdated Show resolved Hide resolved
kalvdans
kalvdans approved these changes Nov 3, 2024
View reviewed changes
Copy link
Contributor

@kalvdans kalvdans left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice! (i don't have write permission though)

@nhz2
Copy link
Contributor Author

nhz2 commented Nov 4, 2024

Thank you for the review

@FrancescAlted FrancescAlted merged commit 2d19aba into Blosc:main Nov 4, 2024
18 checks passed
@FrancescAlted
Copy link
Member

Thanks @nhz2 !

@nhz2 nhz2 deleted the nhz2/move-getenv branch November 4, 2024 12:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kalvdans kalvdans kalvdans approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

getenv used in blosc_compress_ctx
3 participants
@nhz2 @FrancescAlted @kalvdans