Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add GitHub Actions CI workflow for CMake. #291

Merged
merged 1 commit into from
Apr 26, 2020

Conversation

nmoinvaz
Copy link
Member

@nmoinvaz nmoinvaz commented Apr 24, 2020

This PR adds GitHub Actions CI for CMake. It installs pre-requisite packages if needed, generates project files, and compiles them. Then it will run all the CMake tests.

AFAIK GitHub Actions shared runners support AVX2 so #138 may not be necessary.

@nmoinvaz
Copy link
Member Author

You should be able to remove both AppVeyor and Travis CI. I can include that in this PR if you want.

@nmoinvaz
Copy link
Member Author

Here is an example of what the GitHub Actions CI looks like:
https://github.com/nmoinvaz/c-blosc/actions/runs/87089046

@FrancescAlted
Copy link
Member

Looks really good to me. I like the variety of scenarios that you are testing, specially SSE2/AVX2 deactivation and the possibility to link (or not) with external codecs. I think I am going to merge and deactivate TravisCI and AppVeyor promptly. Thank you!

@FrancescAlted FrancescAlted merged commit 4bda5c4 into Blosc:master Apr 26, 2020
@nmoinvaz
Copy link
Member Author

Thanks! I will do one for c-blosc2 next.

@nmoinvaz
Copy link
Member Author

nmoinvaz commented Apr 26, 2020

For some reason AppVeyor is still showing up for the checks for this project.

image

https://ci.appveyor.com/project/FrancescAlted/c-blosc/builds/32449492

@FrancescAlted
Copy link
Member

Good point. I deactivated the webhooks for AppVeyor and TravisCI. This should fix it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants