Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Carthage Support #64

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Carthage Support #64

wants to merge 2 commits into from

Conversation

rroy1590
Copy link

@rroy1590 rroy1590 commented Dec 9, 2015

  • expose a shared framework scheme
  • by default exposed all non-example app headers
  • slightly modify imports because build was complaining about not finding UIColor in a category header

@rroy1590
Copy link
Author

rroy1590 commented Dec 9, 2015

To test this integration without a doing a release yourself please point your Cartfile to "rroy1590/KVNProgress". I have created a tag for this commit here: https://github.com/rroy1590/KVNProgress/releases/tag/2.2.3

@rroy1590 rroy1590 mentioned this pull request Dec 9, 2015
Open
kevin-hirsch
kevin-hirsch requested changes Sep 15, 2016
View reviewed changes
Copy link
Collaborator

@kevin-hirsch kevin-hirsch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hello @rroy1590,

Thanks a lot for this PR! Everything seems fine 👌
I would just change the names of the schemes/targets to Demo and KVNProgress so the actual lib available through Carthage will be KVNProgress and not KVNProgressKit. I did this for one of my other project: DropDown. Here's a screenshot of the configuration:
screen shot 2016-09-15 at 10 51 33

@darecki
Copy link

darecki commented May 22, 2019

Hey guys. Do you think it's possible to finalise the Carthage support anytime soon?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kevin-hirsch kevin-hirsch kevin-hirsch requested changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@rroy1590 @darecki @kevin-hirsch